Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardized country data API #170

Merged
merged 6 commits into from
Sep 23, 2024

Conversation

Disura-Randunu
Copy link
Contributor

Purpose

The purpose of this PR is to fix #155

Goals

To implement a standardized country API endpoint to be used within the application

Approach

Created a model, migration file & seeder. Added related service and route files which can be used in other parts of the application. JSON data file must be in the same directory as the seed file in build directory

Screenshots

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Related PRs

Test environment

Learning

@Disura-Randunu
Copy link
Contributor Author

@anjula-sack Made the PR for countries API.

src/scripts/seed-db-countries.ts Outdated Show resolved Hide resolved
Copy link
Member

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! @Disura-Randunu

@anjula-sack anjula-sack merged commit 400b8fd into sef-global:main Sep 23, 2024
1 check passed
@Disura-Randunu Disura-Randunu mentioned this pull request Sep 29, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement standardized country flag data for mentor profiles
2 participants